Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 1 Nov 2007 00:51:18 +0300
From:      Andrey Chernov <ache@nagual.pp.ru>
To:        Bruce Evans <brde@optusnet.com.au>
Cc:        cvs-src@FreeBSD.ORG, Scott Long <scottl@samsco.org>, src-committers@FreeBSD.ORG, d@delphij.net, cvs-all@FreeBSD.ORG
Subject:   Re: cvs commit: src/lib/libc/locale utf8.c
Message-ID:  <20071031215117.GB89932@nagual.pp.ru>
In-Reply-To: <20071031205412.U3526@delplex.bde.org>
References:  <200710150951.l9F9pUm7026506@repoman.freebsd.org> <4720B30F.4040903@samsco.org> <20071025151707.GA11398@nagual.pp.ru> <4720E0AF.1010004@samsco.org> <4720E904.2090704@delphij.net> <20071031205412.U3526@delplex.bde.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Oct 31, 2007 at 09:41:13PM +1100, Bruce Evans wrote:
> Now the limit is spelled 128, so it really is constant and won't cause
> problems unless the constant changes.

Only in one particular case, the rest cases still need __mb_sb_limit.

> _ctype.h still declares __mb_sb_limit but now doesn't use it.

Do you mean 6x _ctype.h? 8x _ctype.h uses it.

> __mb_sb_limit is still initialized in many files in libc/locale.  These
> initializations now seem to be unused.  Some of them are to 256, so why
> is the constant only 128?

As I already say, there is 3 cases left where it is non-constant.

> __mb_sb_limit is still in Symbol.map.  I think this would be needed if
> __mb_sb_limit were actually used (since although it is now private to
> the library, it would be part of an inter-library ABI if it were used).

It is actually used (for __sbmaskrune, __sbtoupper and __sbtolower).

-- 
http://ache.pp.ru/



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20071031215117.GB89932>