Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 1 Aug 2015 19:03:31 -0700
From:      Garrett Cooper <yaneurabeya@gmail.com>
To:        Baptiste Daroussin <bapt@FreeBSD.org>
Cc:        "src-committers@freebsd.org" <src-committers@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "svn-src-head@freebsd.org" <svn-src-head@freebsd.org>
Subject:   Re: svn commit: r286173 - head/usr.sbin/pw/tests
Message-ID:  <171F8C8E-9FEC-4F30-BF9D-42F3D74F6B50@gmail.com>
In-Reply-To: <201508020033.t720XZrA027708@repo.freebsd.org>
References:  <201508020033.t720XZrA027708@repo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help

> On Aug 1, 2015, at 17:33, Baptiste Daroussin <bapt@FreeBSD.org> wrote:
>=20
> Author: bapt
> Date: Sun Aug  2 00:33:34 2015
> New Revision: 286173
> URL: https://svnweb.freebsd.org/changeset/base/286173
>=20
> Log:
>  Remove netbsd tests on pw(8)
>=20
>  First they are redundant with the tests we currently have on pw(8)
>  Second they to modify the host database instead of being self contained w=
ithing
>  the test directory
>=20
> Modified:
>  head/usr.sbin/pw/tests/Makefile
>=20
> Modified: head/usr.sbin/pw/tests/Makefile
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D
> --- head/usr.sbin/pw/tests/Makefile    Sun Aug  2 00:24:21 2015    (r28617=
2)
> +++ head/usr.sbin/pw/tests/Makefile    Sun Aug  2 00:33:34 2015    (r28617=
3)
> @@ -1,8 +1,5 @@
> # $FreeBSD$
>=20
> -TESTSRC=3D    ${.CURDIR}/../../../contrib/netbsd-tests/usr.sbin/useradd
> -.PATH: ${TESTSRC}
> -
> TESTSDIR=3D    ${TESTSBASE}/usr.sbin/pw
>=20
> ATF_TESTS_SH=3D    pw_etcdir \
> @@ -24,12 +21,4 @@ FILES=3D        group helper_functions.shin mast
>        pw-modified.conf
> FILESDIR=3D       ${TESTSDIR}
>=20
> -ATF_TESTS_SH+=3D    pw_test
> -# - user{add,del} does not exist on FreeBSD; use pw user{add,del} instead=

> -# - The command passes on FreeBSD
> -ATF_TESTS_SH_SED_pw_test=3D    -e 's/useradd /pw useradd /'
> -ATF_TESTS_SH_SED_pw_test+=3D    -e 's/userdel /pw userdel /'
> -ATF_TESTS_SH_SED_pw_test+=3D    -e '/atf_expect_fail "PR bin\/39546"/d'
> -ATF_TESTS_SH_SRC_pw_test=3D    t_useradd.sh
> -
> .include <bsd.test.mk>

You forgot to add an ObsoleteFiles.inc entry..=



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?171F8C8E-9FEC-4F30-BF9D-42F3D74F6B50>