Date: Wed, 20 Oct 2004 00:51:28 +0200 From: Andre Oppermann <andre@freebsd.org> To: Robert Watson <rwatson@freebsd.org> Cc: cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/netinet ip_divert.c Message-ID: <41759A70.11BF9238@freebsd.org> References: <Pine.NEB.3.96L.1041019182730.81058K-100000@fledge.watson.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Robert Watson wrote: > > On Wed, 20 Oct 2004, Andre Oppermann wrote: > > > Hmm... I'll take a look at those attempts and see what I can come up > > with to get some general solution for the protocol cases. The approach > > of callout_drain() looks promising though. > > BTW, it looks like the divert pcb zone uses UMA_ZONE_NOFREE so that the > memory is type-stable (presumably in particular for the sysctl), so all > memory allocated by the divert module for pcbs is likely leaked on unload. > I'm beginning to think we should just block unload for divert and solve > the unload problem another day for another protocol... It is indeed an oversight by me not to uma_zdestroy() the zone on unload. The sysctl handler uses normal malloc. -- Andre
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?41759A70.11BF9238>