Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 19 Mar 2019 15:52:41 -0700
From:      Gleb Smirnoff <glebius@freebsd.org>
To:        "Andrey V. Elsukov" <ae@freebsd.org>
Cc:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   Re: svn commit: r345274 - in head: sbin/ipfw sys/conf sys/modules/ipfw_nat64 sys/netinet6 sys/netpfil/ipfw/nat64
Message-ID:  <20190319225241.GS3562@FreeBSD.org>
In-Reply-To: <2eb41483-24b5-0711-3798-7bf53dd5e716@FreeBSD.org>
References:  <201903181259.x2ICx94D013948@repo.freebsd.org> <20190318230943.GR3562@FreeBSD.org> <2eb41483-24b5-0711-3798-7bf53dd5e716@FreeBSD.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Mar 19, 2019 at 10:45:11AM +0300, Andrey V. Elsukov wrote:
A> > On Mon, Mar 18, 2019 at 12:59:09PM +0000, Andrey V. Elsukov wrote:
A> > A> Author: ae
A> > A> Date: Mon Mar 18 12:59:08 2019
A> > A> New Revision: 345274
A> > A> URL: https://svnweb.freebsd.org/changeset/base/345274
A> > A> 
A> > A> Log:
A> > A>   Update NAT64LSN implementation:
A> > ...
A> > A>   o ConcurrencyKit and epoch(9) is used to make NAT64LSN lockless on fast path.
A> > 
A> > Why did you create a separate epoch? All the pfil hooks already run at network
A> > epoch.
A> 
A> Hi,
A> 
A> You did not specified, when you plan to merge you changes. I assume that
A> you didn't plan to do that. :)

Do you mean to stable/12? In that case better to add epochs with the merge
rather than to head.

-- 
Gleb Smirnoff



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20190319225241.GS3562>