Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 25 Feb 2003 15:38:17 -0800 (PST)
From:      Nate Lawson <nate@root.org>
To:        Kirk McKusick <mckusick@FreeBSD.org>
Cc:        src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org
Subject:   Re: cvs commit: src/sys/ufs/ffs ffs_vfsops.c
Message-ID:  <Pine.BSF.4.21.0302251535400.64658-100000@root.org>
In-Reply-To: <200302252321.h1PNL9T7021673@repoman.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, 25 Feb 2003, Kirk McKusick wrote:
>   Modified files:
>     sys/ufs/ffs          ffs_vfsops.c 
>   Log:
>   Change the field used to test whether the superblock has been updated
>   from the filesystem size field to the filesystem maximum blocksize
>   field. The problem is that older versions of growfs updated only the
>   new size field and not the old size field. This resulted in the old
>   (smaller) size field being copied up to the new size field which
>   caused the filesystem to appear to fsck to be badly trashed.
>   
>   This also adds a sanity check to ensure that the superblock is not
>   being updated when the filesystem is mounted read-only. Obviously
>   such an update should never happen.

Thanks!  For others' benefit, this fixes a long-standing problem that
started happening for me around Dec. 1 where ffs_sbupdate would trash
fs_dsize on unmount.  Those who had similar problems should try this
patch.

I'll try to put together a patch for growfs to address the new sb fields.

-Nate


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-src" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.BSF.4.21.0302251535400.64658-100000>