Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 21 Apr 2009 22:01:38 +0400
From:      Stanislav Sedov <stas@FreeBSD.org>
To:        "M. Warner Losh" <imp@bsdimp.com>
Cc:        stas@freebsd.org, svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org
Subject:   Re: svn commit: r191322 - in head/sys: arm/conf dev/iicbus
Message-ID:  <20090421220138.f6e7b4d4.stas@FreeBSD.org>
In-Reply-To: <20090421.092505.-1186699961.imp@bsdimp.com>
References:  <200904201547.n3KFl6Z6050834@svn.freebsd.org> <20090421.092505.-1186699961.imp@bsdimp.com>

next in thread | previous in thread | raw e-mail | index | archive | help
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Tue, 21 Apr 2009 09:25:05 -0600 (MDT)
"M. Warner Losh" <imp@bsdimp.com> mentioned:

> In message: <200904201547.n3KFl6Z6050834@svn.freebsd.org>
>             Stanislav Sedov <stas@freebsd.org> writes:
> : Author: stas
> : Date: Mon Apr 20 15:47:06 2009
> : New Revision: 191322
> : URL: http://svn.freebsd.org/changeset/base/191322
> : 
> : Log:
> :   - Give a warning and start the oscillator if it was not previously
> :     runned.
> :   - Rename ds1672 -> rtc to follow the other drivers.
> 
> This is a bad change.  Please back it out.  There are multiple
> different kinds of rtc clocks that can live on i2c.
> 

Why do you want to? We already have ds133x under the same name. In case
if there're multiple clocks in the same systems the first one will
have the name of rtc0, the second - rtc1 and so on. Before the names
of devices were ds16720, ds16721, which I looks ugly. 

- -- 
Stanislav Sedov
ST4096-RIPE
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.9 (FreeBSD)

iEYEARECAAYFAknuCggACgkQK/VZk+smlYHkOgCdF+J6pfLTJZal8ll0tJyq1GHW
dIEAn3ggk76n9Jn8rNwplDnsb9HeZwd9
=bfLr
-----END PGP SIGNATURE-----

!DSPAM:49ee0993967001275275125!





Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20090421220138.f6e7b4d4.stas>