Date: Mon, 10 Jan 2000 14:30:19 -0800 (PST) From: "Rodney W. Grimes" <freebsd@gndrsh.dnsmgr.net> To: groudier@club-internet.fr (Gerard Roudier) Cc: mjacob@feral.com (Matthew Jacob), peter@netplex.com.au (Peter Wemm), obrien@NUXI.com, jedgar@fxp.org (Chris D. Faulhaber), cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/i386/conf GENERIC LINT Message-ID: <200001102230.OAA22842@gndrsh.dnsmgr.net> In-Reply-To: <Pine.LNX.3.95.1000110222547.358A-100000@localhost> from Gerard Roudier at "Jan 10, 2000 11:03:56 pm"
next in thread | previous in thread | raw e-mail | index | archive | help
> On Mon, 10 Jan 2000, Rodney W. Grimes wrote: > > > .. > > > > In either case, NCR needs to be modified so sanity happens. The trouble is > > > > that the nominal owner of NCR, Stefan Esser, doesn't seem to be involved > > > > here- otherwise any one of you, David O'Brien, Me, Rodney, whomever, can > > > > just do the right thing. > > > > > > I feel myself quite involved also in the ncr. The fact that I haven't yet > > > proposed any change for this driver is because I have limited time. > > > > > > My proposal about ncr/sym coexistence can be illustrated by the following > > > minute diffs (quite untested and incomplete). > > > > .. > > > > > > If my proposal gets accepted, I will prepare the corresponding changes. > > > I also want to document them in the sym man page I intend to write asap > > > (modulo the time I will have for that). > > > > > > Could people that are interested in that topic let me know if they agree > > > or not with my proposal. Thanks. > > > > This is probably the best solution around. > > Thanks for your reply and agreement. > > And it works just fine. I just gave the tiny real changes below a try and > all behaved as expected: The only concern I have left is order of probes, but as long as no one screws with the files file we should be okay. (Perhaps a comment near the sym and ncr drivers in sys/conf/files would help? ) > > Index: sym_hipd.c > =================================================================== > RCS file: /home/ncvs/src/sys/dev/sym/sym_hipd.c,v > retrieving revision 1.2.2.1 Looks good. > > This is pretty simple and avoids drivers to know too much about each > another. We (I) only must guarantee that both drivers use kind of > compatible chip tables which is easy to check and also to maintain given > that the chip tables are unlikely to evolve very often and that we have to > ensure these tables to be actually fine with the _reality_ of the 53C8XX > chip family. If it happens that things ever went wrong, then either bogus > or incomplete the chip table of one of the drivers would be. > > I donnot want to couple the driver sources more than the above patch does > for the moment. Btw, under Linux the chip table is defined as a big macro > and shared by both the ncr53c8xx and sym53c8xx driver, but both drivers > scan the chip table the same way. We can ever also use a single chip table > for the ncr and the sym, but it is not urgent and I donnot want to fall > into the 'feature of the day' way of developing software that is known to > likely broke things rather than fixing them. Again I agree here. The only last thing that has me concerned is that the ncr driver will now suffer serious bit rot due to lack of use. Any chance of supporting the small collection of older chips from the ncr driver in the sym driver so that ncr.c can just die? -- Rod Grimes - KD7CAX @ CN85sl - (RWG25) rgrimes@gndrsh.dnsmgr.net To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200001102230.OAA22842>