Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 9 Dec 2001 11:20:48 -0700
From:      Nate Williams <nate@yogotech.com>
To:        Matt Dillon <dillon@FreeBSD.org>
Cc:        cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject:   Re: cvs commit: src/usr.sbin/sysinstall install.c label.c sysinstall.h
Message-ID:  <15379.43904.457424.706280@caddis.yogotech.com>
In-Reply-To: <200112090947.fB99lAt24446@freefall.freebsd.org>
References:  <200112090947.fB99lAt24446@freefall.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
> dillon      2001/12/09 01:47:10 PST
> 
>   Modified files:
>     usr.sbin/sysinstall  install.c label.c sysinstall.h 
>   Log:
>   Cleanup sysinstall's 'A'uto partitioning mode to provide more reasonable
>   defaults both in regards to the size of the partitions that are created
>   and in regards to safety and functional separation.
>   
>   Still TODO: extend the previous partition to cover a deleted partition
>   if the previous partiton was auto-created, and supply some sort of
>   solution for /tmp.
>   
>   Reviewed by:    Just about everyone
>   Approved by:    Nobody except maybe my pet mouse fred
>   Obtained from:  God, so complain to HIM
>   MFC after:      1 week

I think this should be backed out, simply because I think the number of
developers who agree with this change is minimal.  Committing something
at this stage is obviously the wrong thing, and is covered by the
handbook, and shouldn't be done.

This is the case where just because a patch exists, doesn't mean the
patch should be committed, because IMHO it's a step backwards, and not
forwards.

(Let the flame-wars continue...)




Nate

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?15379.43904.457424.706280>