Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 24 Nov 2009 17:46:59 +0000 (UTC)
From:      Pyun YongHyeon <yongari@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r199761 - head/sys/dev/bge
Message-ID:  <200911241746.nAOHkxrP025387@svn.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: yongari
Date: Tue Nov 24 17:46:58 2009
New Revision: 199761
URL: http://svn.freebsd.org/changeset/base/199761

Log:
  BGE_FLAG_40BIT_BUG should be set before creating DMA tags.
  
  Pointy hat to:  yongari

Modified:
  head/sys/dev/bge/if_bge.c

Modified: head/sys/dev/bge/if_bge.c
==============================================================================
--- head/sys/dev/bge/if_bge.c	Tue Nov 24 17:15:22 2009	(r199760)
+++ head/sys/dev/bge/if_bge.c	Tue Nov 24 17:46:58 2009	(r199761)
@@ -2665,6 +2665,13 @@ bge_attach(device_t dev)
 	}
 
 	/*
+	 * The 40bit DMA bug applies to the 5714/5715 controllers and is
+	 * not actually a MAC controller bug but an issue with the embedded
+	 * PCIe to PCI-X bridge in the device. Use 40bit DMA workaround.
+	 */
+	if (BGE_IS_5714_FAMILY(sc) && (sc->bge_flags & BGE_FLAG_PCIX))
+		sc->bge_flags |= BGE_FLAG_40BIT_BUG;
+	/*
 	 * Allocate the interrupt, using MSI if possible.  These devices
 	 * support 8 MSI messages, but only the first one is used in
 	 * normal operation.
@@ -2798,13 +2805,6 @@ bge_attach(device_t dev)
 #ifdef DEVICE_POLLING
 	ifp->if_capabilities |= IFCAP_POLLING;
 #endif
-	/*
-	 * The 40bit DMA bug applies to the 5714/5715 controllers and is
-	 * not actually a MAC controller bug but an issue with the embedded
-	 * PCIe to PCI-X bridge in the device. Use 40bit DMA workaround.
-	 */
-	if (BGE_IS_5714_FAMILY(sc) && (sc->bge_flags & BGE_FLAG_PCIX))
-		sc->bge_flags |= BGE_FLAG_40BIT_BUG;
 
 	/*
 	 * 5700 B0 chips do not support checksumming correctly due



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200911241746.nAOHkxrP025387>