Date: Tue, 22 Oct 2019 08:26:46 -0700 From: Gleb Smirnoff <glebius@freebsd.org> To: Enji Cooper <yaneurabeya@gmail.com> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r353732 - head/sys/net Message-ID: <20191022152646.GI4086@FreeBSD.org> In-Reply-To: <21F302BD-CF03-4129-B5DD-7DC3BE481152@gmail.com> References: <201910181520.x9IFKOd2094171@repo.freebsd.org> <21F302BD-CF03-4129-B5DD-7DC3BE481152@gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Oct 22, 2019 at 07:53:31AM -0700, Enji Cooper wrote: E> > Author: glebius E> > Date: Fri Oct 18 15:20:24 2019 E> > New Revision: 353732 E> > URL: https://svnweb.freebsd.org/changeset/base/353732 E> > E> > Log: E> > Make rt_getifa_fib() static. E> E> Why should it be made static? The answer to this question is missing from the commit message. Because a function used only in a scope of a single file and not intended to be used outside should be made static. -- Gleb Smirnoff
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20191022152646.GI4086>