Date: Tue, 21 Apr 2009 12:18:05 -0600 (MDT) From: "M. Warner Losh" <imp@bsdimp.com> To: stas@FreeBSD.org Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: svn commit: r191322 - in head/sys: arm/conf dev/iicbus Message-ID: <20090421.121805.-1954387331.imp@bsdimp.com> In-Reply-To: <20090421220138.f6e7b4d4.stas@FreeBSD.org> References: <200904201547.n3KFl6Z6050834@svn.freebsd.org> <20090421.092505.-1186699961.imp@bsdimp.com> <20090421220138.f6e7b4d4.stas@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
In message: <20090421220138.f6e7b4d4.stas@FreeBSD.org>
Stanislav Sedov <stas@FreeBSD.org> writes:
: -----BEGIN PGP SIGNED MESSAGE-----
: Hash: SHA1
:
: On Tue, 21 Apr 2009 09:25:05 -0600 (MDT)
: "M. Warner Losh" <imp@bsdimp.com> mentioned:
:
: > In message: <200904201547.n3KFl6Z6050834@svn.freebsd.org>
: > Stanislav Sedov <stas@freebsd.org> writes:
: > : Author: stas
: > : Date: Mon Apr 20 15:47:06 2009
: > : New Revision: 191322
: > : URL: http://svn.freebsd.org/changeset/base/191322
: > :
: > : Log:
: > : - Give a warning and start the oscillator if it was not previously
: > : runned.
: > : - Rename ds1672 -> rtc to follow the other drivers.
: >
: > This is a bad change. Please back it out. There are multiple
: > different kinds of rtc clocks that can live on i2c.
: >
:
: Why do you want to? We already have ds133x under the same name. In case
: if there're multiple clocks in the same systems the first one will
: have the name of rtc0, the second - rtc1 and so on.
Because you'll want to support a range of boards that might have
multiple different kinds of rtc i2c clocks. Calling them all i2c
won't work because you can't probe the i2c bus in any meaningful way.
the ds133x one, if it is named rtc, is wrong too.
: Before the names of devices were ds16720, ds16721, which I looks
: ugly.
That's not a good enough reason to change it. That's a cosmetic issue
that is much less important than the functional issue I raised above.
Warner
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20090421.121805.-1954387331.imp>