Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 27 Sep 2018 18:32:15 +0000 (UTC)
From:      Gordon Tetlow <gordon@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-releng@freebsd.org
Subject:   svn commit: r338979 - in releng: 11.1/sys/kern 11.2/sys/kern
Message-ID:  <201809271832.w8RIWFxV073579@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: gordon
Date: Thu Sep 27 18:32:14 2018
New Revision: 338979
URL: https://svnweb.freebsd.org/changeset/base/338979

Log:
  Fix NULL pointer dereference in freebsd4_getfsstat. [EN-18:10.syscall]
  
  Reported by:	Thomas Barabosch, Fraunhofer FKIE
  Approved by:	so
  Security:	FreeBSD-EN-18:10.syscall
  Security:	CVE-2018-17154

Modified:
  releng/11.1/sys/kern/vfs_syscalls.c
  releng/11.2/sys/kern/vfs_syscalls.c

Modified: releng/11.1/sys/kern/vfs_syscalls.c
==============================================================================
--- releng/11.1/sys/kern/vfs_syscalls.c	Thu Sep 27 18:29:55 2018	(r338978)
+++ releng/11.1/sys/kern/vfs_syscalls.c	Thu Sep 27 18:32:14 2018	(r338979)
@@ -641,6 +641,8 @@ freebsd4_getfsstat(td, uap)
 	size = count * sizeof(struct statfs);
 	error = kern_getfsstat(td, &buf, size, &count, UIO_SYSSPACE,
 	    uap->mode);
+	if (buf == NULL)
+		return (EINVAL);
 	td->td_retval[0] = count;
 	if (size != 0) {
 		sp = buf;

Modified: releng/11.2/sys/kern/vfs_syscalls.c
==============================================================================
--- releng/11.2/sys/kern/vfs_syscalls.c	Thu Sep 27 18:29:55 2018	(r338978)
+++ releng/11.2/sys/kern/vfs_syscalls.c	Thu Sep 27 18:32:14 2018	(r338979)
@@ -600,6 +600,8 @@ freebsd4_getfsstat(struct thread *td, struct freebsd4_
 	size = count * sizeof(struct statfs);
 	error = kern_getfsstat(td, &buf, size, &count, UIO_SYSSPACE,
 	    uap->mode);
+	if (buf == NULL)
+		return (EINVAL);
 	td->td_retval[0] = count;
 	if (size != 0) {
 		sp = buf;



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201809271832.w8RIWFxV073579>