Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 25 Sep 2006 06:52:36 +0800 (CST)
From:      Yi-Hsuan Hsin <mhsin@mhsin.org>
To:        FreeBSD-gnats-submit@FreeBSD.org
Cc:        mhsin@mhsin.org, vanilla@FreeBSD.org
Subject:   ports/103597: [PATCH] irc/irssi: Fixes overlong topic issue.
Message-ID:  <20060924225236.1825210081@Ada.mhsin.org>
Resent-Message-ID: <200609242300.k8ON0bhZ016328@freefall.freebsd.org>

next in thread | raw e-mail | index | archive | help

>Number:         103597
>Category:       ports
>Synopsis:       [PATCH] irc/irssi: Fixes overlong topic issue.
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sun Sep 24 23:00:36 GMT 2006
>Closed-Date:
>Last-Modified:
>Originator:     Yi-Hsuan Hsin
>Release:        FreeBSD 4.10-RELEASE-p16 i386
>Organization:
NTU CSIE
>Environment:
System: FreeBSD a.mhsin.org 4.10-RELEASE-p16 FreeBSD 4.10-RELEASE-p16 #13: Fri Jul  1 03:06:45 CST
>Description:

When irssi displays a overlong topic with wide (width > 1) character on the
display margin, it will truncate AFTER that character. That is, the whole wide
character is outputted and mess up the screen.
This patch fixes the problem by truncating BEFORE wide characters that fall
on the display margin.

Added file(s):
- files/patch-topic_length

Port maintainer (vanilla@FreeBSD.org) is cc'd.

Generated with FreeBSD Port Tools 0.77
>How-To-Repeat:
>Fix:

--- irssi-0.8.10_3.patch begins here ---
diff -ruN --exclude=CVS /usr/ports/irc/irssi.orig/Makefile /usr/ports/irc/irssi/Makefile
--- /usr/ports/irc/irssi.orig/Makefile	Tue Sep 19 00:26:04 2006
+++ /usr/ports/irc/irssi/Makefile	Mon Sep 25 06:38:50 2006
@@ -7,7 +7,7 @@
 
 PORTNAME=	irssi
 PORTVERSION=	0.8.10
-PORTREVISION?=	2
+PORTREVISION?=	3
 CATEGORIES?=	irc
 MASTER_SITES=	http://mirror.irssi.org/
 
diff -ruN --exclude=CVS /usr/ports/irc/irssi.orig/files/patch-topic_length /usr/ports/irc/irssi/files/patch-topic_length
--- /usr/ports/irc/irssi.orig/files/patch-topic_length	Thu Jan  1 08:00:00 1970
+++ /usr/ports/irc/irssi/files/patch-topic_length	Mon Sep 25 06:27:31 2006
@@ -0,0 +1,21 @@
+--- src/fe-common/core/formats.c.orig	Fri Dec  9 01:32:44 2005
++++ src/fe-common/core/formats.c	Mon Sep 25 06:15:26 2006
+@@ -376,6 +376,7 @@
+ 	GString *tmp;
+ 	const char *start;
+ #ifdef HAVE_GLIB2
++	const char *oldstr;
+ 	gboolean utf8;
+ #endif
+ 	g_return_val_if_fail(str != NULL, 0);
+@@ -404,7 +405,10 @@
+ 		}
+ 
+ #ifdef HAVE_GLIB2
++		oldstr = str;
+ 		len -= advance(&str, utf8);
++		if(len < 0)
++			str = oldstr;
+ #else
+ 	  len--;
+ 		str++;
--- irssi-0.8.10_3.patch ends here ---

>Release-Note:
>Audit-Trail:
>Unformatted:



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20060924225236.1825210081>