Date: Mon, 23 Mar 2015 09:20:26 +0100 From: John Marino <freebsd.contact@marino.st> To: Alexey Dokuchaev <danfe@FreeBSD.org>, Bryan Drewery <bdrewery@FreeBSD.org> Cc: Sunpoet Po-Chuan Hsieh <sunpoet@FreeBSD.org>, svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r381955 - head/graphics/gdal Message-ID: <550FCCCA.2010308@marino.st> In-Reply-To: <20150323032725.GA55962@FreeBSD.org> References: <201503222011.t2MKBHq7091087@svn.freebsd.org> <20150323015759.GA34402@FreeBSD.org> <550F8505.8010600@FreeBSD.org> <20150323032725.GA55962@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 3/23/2015 04:27, Alexey Dokuchaev wrote: > On Sun, Mar 22, 2015 at 10:14:13PM -0500, Bryan Drewery wrote: >> On 3/22/2015 8:58 PM, Alexey Dokuchaev wrote: >>> On Sun, Mar 22, 2015 at 08:11:17PM +0000, Sunpoet Po-Chuan Hsieh wrote: >>>> New Revision: 381955 >>>> URL: https://svnweb.freebsd.org/changeset/ports/381955 >>>> QAT: https://qat.redports.org/buildarchive/r381955/ >>>> >>>> Log: >>>> - Use -lpthread instead of -pthread >>> >>> Is -pthread going away anytime soon? I'm a bit worried of more alike >>> changing one to another; since they're identical right now on FreeBSD, >>> I'd rather reduce amount of patching, leaving whatever is picked by >>> upstream, unless -lpthread really should be preferred over -pthread >>> for some reason I'm unaware of (and ready to learn about). >> >> It's a pointless change. Tijl explains here >> https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=198116#c4 > > Right; I'm aware of Tijl's excellent explanation (broader version he posted > on the lists) and given that it is a pointless change, I used this occasion > to remind that commits that merely change one to another should be avoided. > It's not pointless; people are patching good "-lpthread" to be "-pthread" even today, and it's hard to tell them to stop when the default PTHREADS_LIBS is "-pthread". Also, this is not what tijl has been saying -- his stance was to stop using -pthread. We need not to add more -pthread, we need to remove patches and sed of -lpthread to -pthread, and to do that we need to start at the infrastructure to avoid sending a mixed message. patching -lpthread to -pthread is simply wrong now, and the message needs to get out. John
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?550FCCCA.2010308>