Date: Tue, 23 Dec 2008 23:39:09 +0100 From: Hartmut Brandt <hartmut.brandt@dlr.de> To: Kip Macy <kip.macy@gmail.com> Cc: Qing Li <qingli@freebsd.org>, "Li, Qing" <qing.li@bluecoat.com>, freebsd-current@freebsd.org, freebsd-net@freebsd.org Subject: Re: HEADSUP: arp-v2 has been committed Message-ID: <4951688D.5080202@dlr.de> In-Reply-To: <3c1674c90812231408h53b16b4as5d3fa242e6d02a10@mail.gmail.com> References: <55f001c9639d$875f14ec$7202020a@internal.cacheflow.com> <4950F770.3090700@dlr.de> <B583FBF374231F4A89607B4D08578A4302A8BCC4@bcs-mail03.internal.cacheflow.com> <3c1674c90812231408h53b16b4as5d3fa242e6d02a10@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Hi Kip, Kip Macy wrote: >>> And another point: when changing external interfaces it might be >>> possible to ask for a full port build with the changes to look for the >>> fall-out on ports. I would say that this commit was a good candidate >>> >> to >> >>> get the port maintainers into the boat earlier. >>> >>> not so happy, >>> > > The only reasonable way to do a full ports build is to ask portmgr to > use the build systems. Although it may now be possible with svn, in > the past there was no way for him to do that for out of tree code. > Hence portmgr does not share your point of view. > Well, they did this in the past, for example when I did some heavy work on make(1). At that time Kris did this, I don't know through which magic, though. > What we should have done is grepped for RTM_RESOLVE and the flags that > I removed. However, that did not occur to me. He asked on numerous > occasions for review and someone should have brought it up then. We do > not feel that it is reasonable to hold him solely responsible when he > did not act in a unilateral fashion. > > I usually take care of stuff that touches anything that has to do with the SNMP stuff, but this time the triggering did not work. I probably was sure that people will directly mail before touching someting in src/contrib. > Thank you for taking care of that bit of breakage. > No problem. That was a good kick to finally look how this vendor import stuff works and get the next import prepared. Don't take it too serious, 't was just a bad day (it started with a broken cup :-) harti
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4951688D.5080202>