Date: Wed, 02 Jul 2014 17:56:48 +0200 From: Jakub Klama <jakub.klama@uj.edu.pl> To: Hans Petter Selasky <hps@selasky.org> Cc: src-committers@freebsd.org, Jakub Wojciech Klama <jceel@FreeBSD.org>, svn-src-user@freebsd.org Subject: Re: svn commit: r268163 - in =?UTF-8?Q?user/jceel/soc=32=30=31=34?= =?UTF-8?Q?=5Fevdev/head/sys=3A=20conf=20dev/evdev?= Message-ID: <2949d0e28da9b3475784b04db40a8127@uj.edu.pl> In-Reply-To: <53B428CD.6040402@selasky.org> References: <201407021540.s62FePTQ029148@svn.freebsd.org> <53B428CD.6040402@selasky.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, 02 Jul 2014 17:44:13 +0200, Hans Petter Selasky wrote:
> On 07/02/14 17:40, Jakub Wojciech Klama wrote:
>> +static int
>> +uinput_poll(struct cdev *dev, int events, struct thread *td)
>> +{
>> + struct uinput_cdev_state *state;
>> + int ret;
>> + int revents = 0;
>> +
>> + debugf("cdev: poll by thread %d", td->td_tid);
>> +
>> + ret = devfs_get_cdevpriv((void **)&state);
>> + if (ret != 0)
>> + return (ret);
>
> Hi,
>
> In case of error "poll" returns POLLNVAL, I think.
Hi Hans,
Actually, whole uinput_poll() code is bogus and will be
corrected - all that poll() on uinput node should do is
to always allow write.
However, thanks for pointing that out - same piece of code
exists in evdev/cdev.c, where it actually needs to be fixed.
Jakub
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?2949d0e28da9b3475784b04db40a8127>