Date: Fri, 22 Oct 2010 16:00:00 +0000 (UTC) From: Matthew D Fleming <mdf@FreeBSD.org> To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-8@freebsd.org Subject: svn commit: r214206 - in stable/8: share/man/man9 sys/vm Message-ID: <201010221600.o9MG00a7059121@svn.freebsd.org>
next in thread | raw e-mail | index | archive | help
Author: mdf Date: Fri Oct 22 16:00:00 2010 New Revision: 214206 URL: http://svn.freebsd.org/changeset/base/214206 Log: MFC r214062: uma_zfree(zone, NULL) should do nothing, to match free(9). Noticed by: Ron Steinke <rsteinke at isilon dot com> Modified: stable/8/share/man/man9/zone.9 stable/8/sys/vm/uma_core.c Directory Properties: stable/8/share/man/man9/ (props changed) stable/8/sys/ (props changed) stable/8/sys/amd64/include/xen/ (props changed) stable/8/sys/cddl/contrib/opensolaris/ (props changed) stable/8/sys/contrib/dev/acpica/ (props changed) stable/8/sys/contrib/pf/ (props changed) stable/8/sys/dev/xen/xenpci/ (props changed) Modified: stable/8/share/man/man9/zone.9 ============================================================================== --- stable/8/share/man/man9/zone.9 Fri Oct 22 14:07:12 2010 (r214205) +++ stable/8/share/man/man9/zone.9 Fri Oct 22 16:00:00 2010 (r214206) @@ -147,6 +147,13 @@ Items are released back to the zone from calling .Fn uma_zfree with a pointer to the zone and a pointer to the item. +If +.Fa item +is +.Dv NULL , +then +.Fn uma_zfree +does nothing. .Pp The variations .Fn uma_zalloc_arg Modified: stable/8/sys/vm/uma_core.c ============================================================================== --- stable/8/sys/vm/uma_core.c Fri Oct 22 14:07:12 2010 (r214205) +++ stable/8/sys/vm/uma_core.c Fri Oct 22 16:00:00 2010 (r214206) @@ -2519,6 +2519,10 @@ uma_zfree_arg(uma_zone_t zone, void *ite CTR2(KTR_UMA, "uma_zfree_arg thread %x zone %s", curthread, zone->uz_name); + /* uma_zfree(..., NULL) does nothing, to match free(9). */ + if (item == NULL) + return; + if (zone->uz_dtor) zone->uz_dtor(item, zone->uz_size, udata);
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201010221600.o9MG00a7059121>