Date: Tue, 17 Dec 2019 00:10:19 +0000 (UTC) From: Brooks Davis <brooks@FreeBSD.org> To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r355830 - head/sys/dev/ata/chipsets Message-ID: <201912170010.xBH0AJw3085049@repo.freebsd.org>
next in thread | raw e-mail | index | archive | help
Author: brooks Date: Tue Dec 17 00:10:19 2019 New Revision: 355830 URL: https://svnweb.freebsd.org/changeset/base/355830 Log: Avoid a tautological bitwise compare. This looks like a bit of debugging code that sliped into the initial import of the new ATA framework. This changes the behavior to omit a line of output that appears to have been intended for omission. Reviewed by: mav MFC after: 3 days Sponsored by: DARPA, AFRL Differential Revision: https://reviews.freebsd.org/D22845 Modified: head/sys/dev/ata/chipsets/ata-promise.c Modified: head/sys/dev/ata/chipsets/ata-promise.c ============================================================================== --- head/sys/dev/ata/chipsets/ata-promise.c Tue Dec 17 00:00:03 2019 (r355829) +++ head/sys/dev/ata/chipsets/ata-promise.c Tue Dec 17 00:10:19 2019 (r355830) @@ -795,7 +795,7 @@ ata_promise_mio_reset(device_t dev) if (ata_sata_phy_reset(dev, -1, 1)) { u_int32_t signature = ch->hw.softreset(dev, ATA_PM); - if (1 | bootverbose) + if (bootverbose) device_printf(dev, "SIGNATURE: %08x\n", signature); switch (signature >> 16) {
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201912170010.xBH0AJw3085049>