Date: Thu, 15 Nov 2018 11:38:25 +0100 From: Joan Picanyol i Puig <pica@biaix.org> To: arrowd@freebsd.org, 6yearold@gmail.com, tcberner@freebsd.org, rakuco@freebsd.org Cc: sunpoet@freebsd.org, python@freebsd.org Subject: Re: tortoisehg freebsd port update Message-ID: <20181115103825.GA74007@grummit.biaix.org> In-Reply-To: <20181114133321.GA58356@grummit.biaix.org> References: <20181114133321.GA58356@grummit.biaix.org>
next in thread | previous in thread | raw e-mail | index | archive | help
[followup, adding PyQT people]
tl;dr: tortoisehg does not work on FreeBSD 11.2 + 2018Q4 ports branch because
of version mismatch
* Joan Picanyol i Puig <pica@biaix.org> [20181114 14:33]:
> Hi there,
>
> Thanks a lot for mantaining tortoisehg and mercurial on FreeBSD. I just
> upgraded to 11.2-RELEASE and as a result presumably started using branch
> 2018Q4. Unfortunately, mercurial & tortoisehg were not in sync when the
> branch was cut:
>
> pk-ets-ws% pkg info tortoisehg-4.6 mercurial-4.7.1
> tortoisehg-4.6
> mercurial-4.7.1
>
> I see that sunpoet@ has upgraded mercurial to 4.8 in HEAD, so I'm unsure
> what the best path forward would be, but I'd vote for upgrading
> tortoisehg to 4.8 as well in HEAD and then MFHing this update and 484134 to 2018Q4.
Unsure whether this is an option to get tortoisehg going unless Qt5 is also
upgraded, or a local patch is kept until then, see below.
> At the very least, I'd kindly request to update tortoisehg to 4.7 so I
> can at least build from source.
Well, that didn't work out too well. Downloading tortoisehg-4.7.1 or 4.7.2 and
trying to run it with python2.7 fails saying:
#!python
** Mercurial version (4.7.1). TortoiseHg version (4.7.1)
** Command:
** CWD: /usr/home/pica/sw
** Encoding: UTF-8
** Extensions loaded: rebase, shelve, extdiff, convert, strip, largefiles, tortoisehg.util.configitems
** Python version: 2.7.15 (default, May 26 2018, 01:11:09) [GCC 4.2.1 Compatible FreeBSD Clang 4.0.0 (tags/RELEASE_400/final 297347)]
** System: FreeBSD pk-ets-ws 11.2-RELEASE-p4 FreeBSD 11.2-RELEASE-p4 #0: Thu Sep 27 08:16:24 UTC 2018 root@amd64-builder.daemonology.net:/usr/obj/usr/src/sys/GENERIC amd64
** Qt-5.10.1 PyQt-5.9.2 QScintilla-2.10.4
Traceback (most recent call last):
File "/usr/home/pica/sw/tortoisehg-4.7.1/tortoisehg/hgqt/run.py", line 70, in dispatch
return _runcatch(u, args)
[... snip ...]
File "/usr/home/pica/sw/tortoisehg-4.7.1/tortoisehg/hgqt/workbench.py", line 80, in __init__
self.mqpatches = p = mq.MQPatchesWidget(self)
File "/usr/home/pica/sw/tortoisehg-4.7.1/tortoisehg/hgqt/mq.py", line 625, in __init__
qtlib.setContextMenuShortcut(a, 'Ctrl+Return')
File "/usr/home/pica/sw/tortoisehg-4.7.1/tortoisehg/hgqt/qtlib.py", line 1474, in setContextMenuShortcut
action.setShortcutVisibleInContextMenu(True)
AttributeError: 'QAction' object has no attribute 'setShortcutVisibleInContextMenu'
However, this method was introduced in Qt 5.10
http://doc.qt.io/qt-5/qaction.html#shortcutVisibleInContextMenu-prop and we
only have Qt 5.9 in ports.
At this point I suggest we update tortoisehg to 4.7.2 with a patch until kde@
upgrades Qt. I've reverted
https://bitbucket.org/tortoisehg/thg/commits/244ff3f444682ee41c934e0c0c977b67f19f835d
locally and can successfully start tortoisehg-4.7.2 with it.
keep up the good work
--
joan
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20181115103825.GA74007>