Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 23 Jul 2003 14:24:00 -0400 (EDT)
From:      John Baldwin <jhb@FreeBSD.org>
To:        Poul-Henning Kamp <phk@FreeBSD.org>
Cc:        cvs-all@FreeBSD.org
Subject:   RE: cvs commit: src/sys/dev/rp rp.c
Message-ID:  <XFMail.20030723142400.jhb@FreeBSD.org>
In-Reply-To: <200307231803.h6NI3NQS017696@repoman.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help

On 23-Jul-2003 Poul-Henning Kamp wrote:
> phk         2003/07/23 11:03:23 PDT
> 
>   FreeBSD src repository
> 
>   Modified files:
>     sys/dev/rp           rp.c 
>   Log:
>   Undo single-intance inlining which is way above the comfort limit for GCC.

Single instance inlining can not hurt.  It can help by reducing call
stack depth and code size however.  I thought you were for reducing code
size, not increasing it.  Please use __always_inline to shut up gcc
instead of de-inlining for single instance inlines.

-- 

John Baldwin <jhb@FreeBSD.org>  <><  http://www.FreeBSD.org/~jhb/
"Power Users Use the Power to Serve!"  -  http://www.FreeBSD.org/



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?XFMail.20030723142400.jhb>