Date: Thu, 6 Oct 2005 17:48:02 +0200 From: Stefan Farfeleder <stefanf@FreeBSD.org> To: Pawel Jakub Dawidek <pjd@FreeBSD.org> Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/libkern strtok.c src/sys/sys libkern.h src/sys/conf files Message-ID: <20051006154754.GH603@wombat.fafoe.narf.at> In-Reply-To: <20051006144454.GF23662@garage.freebsd.pl> References: <200510061110.j96BAApc034176@repoman.freebsd.org> <20051006132738.GG603@wombat.fafoe.narf.at> <20051006144454.GF23662@garage.freebsd.pl>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Oct 06, 2005 at 04:44:54PM +0200, Pawel Jakub Dawidek wrote: > On Thu, Oct 06, 2005 at 03:27:40PM +0200, Stefan Farfeleder wrote: > +> On Thu, Oct 06, 2005 at 11:10:10AM +0000, Pawel Jakub Dawidek wrote: > +> > pjd 2005-10-06 11:10:10 UTC > +> > > +> > FreeBSD src repository > +> > > +> > Modified files: > +> > sys/sys libkern.h > +> > sys/conf files > +> > Added files: > +> > sys/libkern strtok.c > +> > Log: > +> > Add strtok() and strtok_r() function to libkern. > +> > +> Wouldn't it be better to have strsep() instead? > > Actually we do have strsep() libkern already... Oops. Can you please change nfs_diskless.c to use strsep()? I think it's a mistake to add non-reentrant functions to libkern. Stefan
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20051006154754.GH603>