Date: Sun, 4 Oct 2015 13:48:27 +1100 From: Kubilay Kocak <koobs@FreeBSD.org> To: Sunpoet Po-Chuan Hsieh <sunpoet@FreeBSD.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org, Dmitry Marakasov <amdmi3@FreeBSD.org> Subject: Re: svn commit: r398482 - head/devel/py-greenlet Message-ID: <5610937B.1000708@FreeBSD.org> In-Reply-To: <201510031707.t93H7UBs008407@repo.freebsd.org> References: <201510031707.t93H7UBs008407@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 4/10/2015 4:07 AM, Sunpoet Po-Chuan Hsieh wrote: > Author: sunpoet > Date: Sat Oct 3 17:07:29 2015 > New Revision: 398482 > URL: https://svnweb.freebsd.org/changeset/ports/398482 > > Log: > - Convert to new test framework > > Modified: > head/devel/py-greenlet/Makefile > > Modified: head/devel/py-greenlet/Makefile > ============================================================================== > --- head/devel/py-greenlet/Makefile Sat Oct 3 17:07:24 2015 (r398481) > +++ head/devel/py-greenlet/Makefile Sat Oct 3 17:07:29 2015 (r398482) > @@ -12,14 +12,13 @@ COMMENT= Light-weight microthreads for P > > LICENSE= MIT > > +DO_MAKE_TEST= ${PYTHON_CMD} This is horrible & super ugly. Why can't we have / isn't there a TEST_CMD variable to complement TEST_{ARGS,DEPENDS,*} variables? The new test framework is VERY VERY welcome, but I'm worried it needs polishing/refinement for extensibility across the broader ports framework *before* a large number of ports have been 'converted', thereby cementing in an under-baked implementation and making it much harder to change for the better. Another worry is that there isn't an *explicit* opt-in or toggle to enable tests. It is imperative to have a way to enable/disable test mechanisms independently to whether TEST_DEPENDS and other variables are defined or not. CC'ing Dmitry for more feedback. > ONLY_FOR_ARCHS= amd64 i386 > +TEST_TARGET= run-tests.py > USE_PYTHON= autoplist concurrent distutils > USES= python > > post-install: > ${STRIP_CMD} ${STAGEDIR}${PYTHON_SITELIBDIR}/greenlet.so > > -regression-test test: build > - cd ${WRKSRC}/ && ${PYTHON_CMD} run-tests.py > - > .include <bsd.port.mk> >
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?5610937B.1000708>