Date: Wed, 23 Jul 2003 20:32:14 +0200 From: "Poul-Henning Kamp" <phk@phk.freebsd.dk> To: John Baldwin <jhb@FreeBSD.org> Cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/rp rp.c Message-ID: <24542.1058985134@critter.freebsd.dk> In-Reply-To: Your message of "Wed, 23 Jul 2003 14:24:00 EDT." <XFMail.20030723142400.jhb@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
In message <XFMail.20030723142400.jhb@FreeBSD.org>, John Baldwin writes: > >On 23-Jul-2003 Poul-Henning Kamp wrote: >> phk 2003/07/23 11:03:23 PDT >> >> FreeBSD src repository >> >> Modified files: >> sys/dev/rp rp.c >> Log: >> Undo single-intance inlining which is way above the comfort limit for GCC. > >Single instance inlining can not hurt. It can help by reducing call >stack depth and code size however. I thought you were for reducing code >size, not increasing it. Please use __always_inline to shut up gcc >instead of de-inlining for single instance inlines. Please provide data showing actual improvement for inlining. If I changed this to __always_inline, I would change the code generated, to start inlining these functions. We don't know the effect of that. Instead I preserve the status quo by removing the inline request which GCC ignores. -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?24542.1058985134>