Date: Tue, 12 Feb 2013 21:10:16 +0800 From: Martin Wilke <miwi@FreeBSD.org> To: Alexey Dokuchaev <danfe@FreeBSD.org> Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r312091 - in head/audio: . gtmixer Message-ID: <A3FE0961-6FB7-452F-833B-3B9B4393F865@FreeBSD.org> In-Reply-To: <20130212122832.GA82139@FreeBSD.org> References: <201302121005.r1CA5iJj080078@svn.freebsd.org> <20130212122832.GA82139@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
All your comments fixed except from the grammar feel free to fix it.
- Martin
+-----------------oOO--(_)--OOo-------------------------+
With best Regards,
Martin Wilke (miwi_(at)_FreeBSD.org)
Mess with the Best, Die like the Rest
On Feb 12, 2013, at 8:28 PM, Alexey Dokuchaev <danfe@FreeBSD.org> wrote:
> On Tue, Feb 12, 2013 at 10:05:44AM +0000, Martin Wilke wrote:
>> New Revision: 312091
>> URL: http://svnweb.freebsd.org/changeset/ports/312091
>>=20
>> +PORTNAME=3D gtmixer
>> +PORTVERSION=3D 1.0.2
>> +CATEGORIES=3D audio
>> +MASTER_SITES=3D http://github.com/svagner/gtmixer/archive/
>> +DISTNAME=3D ${PORTVERSION}
>=20
> Perhaps USE_GITHUB could be used here?..
>=20
>> +WRKSRC=3D ${WRKDIR}/${PORTNAME}-${PORTVERSION}
>> +FETCH_ARGS=3D -Fpr
>=20
> ... which could also release you from setting FETCH_ARGS. (Setting =
WRKSRC
> also looks weird, but I'm not sure yet if it can be omitted.)
>=20
>> +do-install:
>> + @${MKDIR} ${PREFIX}/share/gtmixer
>> + @${CP} -r ${WRKSRC}/icons ${PREFIX}/share/gtmixer/
>> + @${INSTALL_MAN} ${WRKSRC}/gtmixer.1 ${MAN1PREFIX}/man/man1
>=20
> We do not mute installation commands (muting MKDIR is fine).
>=20
>> +++ head/audio/gtmixer/pkg-descr Tue Feb 12 10:05:43 2013 =
(r312091)
>> @@ -0,0 +1,4 @@
>> +GTMixer is a free, simple graphical mixer for FreeBSD.
>> +Based at GTK 2.0 Lib.
>=20
> Bad grammar, bogus use of contraction and capitalization; also it =
seems port
> description could be augmented a bit.
>=20
> ./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?A3FE0961-6FB7-452F-833B-3B9B4393F865>