Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 13 Feb 2004 15:31:49 -0700 (MST)
From:      Scott Long <scottl@freebsd.org>
To:        Julian Elischer <julian@FreeBSD.org>
Cc:        cvs-all@FreeBSD.org
Subject:   Re: cvs commit: src/sys/dev/bfe if_bfe.c if_bfereg.h
Message-ID:  <20040213152836.U25703@pooker.samsco.home>
In-Reply-To: <200402132136.i1DLaYii065621@repoman.freebsd.org>
References:  <200402132136.i1DLaYii065621@repoman.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, 13 Feb 2004, Julian Elischer wrote:
> julian      2004/02/13 13:36:34 PST
>
>   FreeBSD src repository
>
>   Modified files:        (Branch: RELENG_4)
>     sys/dev/bfe          if_bfe.c if_bfereg.h
>   Log:
>   Upgrade to the version of the MFC by  Edwin Groothuis.
>   This seems to work but I have heard of hangs...
>
>   Revision  Changes    Path
>   1.4.4.3   +101 -91   src/sys/dev/bfe/if_bfe.c
>   1.1.4.3   +12 -0     src/sys/dev/bfe/if_bfereg.h
>
>

Julian,

Are you willing to stand by this commit?  Your comment implies that you
don't know if it works or not.  If so, then RELENG_4 is certainly not the
place for this.  Mr. Groothuis might have done a fine job with this, but
unless you as a committer and senior member of this project are willing
to actually review, test, and validate it, then it needs to be backed out
and revisited at a later date.

Scott



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20040213152836.U25703>