Date: Wed, 01 Nov 2017 12:41:55 +0000 From: bugzilla-noreply@freebsd.org To: freebsd-ports-bugs@FreeBSD.org Subject: [Bug 223361] amsynth port Message-ID: <bug-223361-13-2hzLyl1MC2@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-223361-13@https.bugs.freebsd.org/bugzilla/> References: <bug-223361-13@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D223361 Adam Weinberger <adamw@FreeBSD.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |adamw@FreeBSD.org --- Comment #2 from Adam Weinberger <adamw@FreeBSD.org> --- You're off to a good start here, but there's still lots to be done. NLS needs to be an option. See https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/makefile= -options.html for more details. Either way, your PLIST_SUB is unused, given that you have= no %%NLS%% tags in the pkg-plist. The post-extract is wrong. You're calling commands that haven't been instal= led yet, which leads me to suspect that you haven't tested this in poudriere, w= hich is a requirement of all submissions. Add USES=3Dautoreconf instead and remo= ve that entire post-extract block. The pre.mk/post.mk is unused here. Just call ".include <bsd.port.mk>" at the end. Once you've fixed up those issues, test it in "poudriere testport" and "portlint -AC" and attach the output of both. --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-223361-13-2hzLyl1MC2>