Date: Sun, 26 Mar 2000 11:49:05 -0800 From: Alfred Perlstein <bright@wintelcom.net> To: Poul-Henning Kamp <phk@critter.freebsd.dk> Cc: current@FreeBSD.ORG Subject: Re: vinum possible casulty of B_* patches? Message-ID: <20000326114905.U21029@fw.wintelcom.net> In-Reply-To: <3358.954060855@critter.freebsd.dk>; from phk@critter.freebsd.dk on Sun, Mar 26, 2000 at 10:54:15AM %2B0200 References: <20000326011506.R21029@fw.wintelcom.net> <3358.954060855@critter.freebsd.dk>
next in thread | previous in thread | raw e-mail | index | archive | help
* Poul-Henning Kamp <phk@critter.freebsd.dk> [000326 01:18] wrote:
> In message <20000326011506.R21029@fw.wintelcom.net>, Alfred Perlstein writes:
> >I'm about to wander down vinum's source again.
> >
> >With a kernel and vinum module dated approx Tue Feb 29 06:53:56
> >PST 2000 everything works fine.
> >
> >I recently (tonight) I cvsup'd to 5.0 to play with Matt's SMP stuff
> >and came across a problem where it seems that 5.0 doesn't get any
> >IO down to my vinum striped disks.
> >
> >I'll get panics,
>
> You should know better than expect help providing only this little
> information...
It's pretty obvious that your b_iocmd patches botched vinum up,
you introduced a compiler warning about dead code in the raid5
stuff as well as missing several &= ~B_READ -> biocmd = BIO_WRITE.
* Poul-Henning Kamp <phk@critter.freebsd.dk> chopped out:
> >I'll get panics, but then rebooting both my old and new kernels+modules
> >the vinum volume is "clean" which leads me to belive that somewhere
> >writes just aren't making it through to my disks.
> >
> >If I do a reboot I'll loose something like thousands of buffers
> >but yet my vinum drive is "marked clean" on boot without the need
> >for fsck.
> >
> >Anyhow, I just wanted to let you guys know what's going on hopefully
> >you'll have a solution faster than I will.
Poul, is your mailer broken in such a way that you can't quote the
entire message? I'd appreciate you looking into it because it
makes communicating with you a bit difficult without feeling like
you're intentionally trying to be nasty.
This was intended as heads-up to people using vinum that I found
some nasty breakage as well as a note to the maintainer and you
(the last person to touch vinum) that something went phooey.
I'm sorry, beat me, whip me, eviscerate me, whatever, my /var/crash
is on my vinum volume and obviously without write ability to it,
I'm going to have some issues tracking it down.
Although I agree with the biocmd stuff you did, I was also disapointed
to see that the only official feedback you got (from dillon) asking
for you to hold off until he and Kirk completed some other work,
was completely ignored. In fact the commit coincided within a few
hours of his kindly worded objection.
Frankly you should know better than to commit when:
1) no one is able to review,
2) there are objections, and
3) entire subsystems are kicked in the pants because you're unable
to hold off a couple of days for $MAINTAINER to give it a
look-see.
And if you _must_ commit something under such circumstances then
being nice to the people that you break would er... be the nice
thing to do.
I also don't see how a kinder and gentler phk couldn't have just
reread his own deltas and noticed the glaring ommisions and then
proceed to discuss or fix it rather than jumping down my throat.
thanks,
--
-Alfred Perlstein - [bright@wintelcom.net|alfred@freebsd.org]
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20000326114905.U21029>