Date: Thu, 19 Apr 2018 16:49:43 +0000 From: Brooks Davis <brooks@freebsd.org> To: John Baldwin <jhb@FreeBSD.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r332782 - in head/sys: amd64/linux amd64/linux32 compat/freebsd32 i386/linux kern sys Message-ID: <20180419164943.GA84360@spindle.one-eyed-alien.net> In-Reply-To: <201804191600.w3JG0Y0w077991@repo.freebsd.org> References: <201804191600.w3JG0Y0w077991@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--EeQfGwPcQSOJBaQU Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Apr 19, 2018 at 04:00:34PM +0000, John Baldwin wrote: > Author: jhb > Date: Thu Apr 19 16:00:34 2018 > New Revision: 332782 > URL: https://svnweb.freebsd.org/changeset/base/332782 >=20 > Log: > Simplify the code to allocate stack for auxv, argv[], and environment v= ectors. > =20 > Remove auxarg_size as it was only used once right after a confusing > assignment in each of the variants of exec_copyout_strings(). Thanks! I just tripped over auxarg_size's confusing nature in CheriBSD. I do wonder if allocating AT_COUNT entries is quite right since some are emitted only optionally. That said, it's not as though the waste is significant. -- Brooks --EeQfGwPcQSOJBaQU Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEcBAEBAgAGBQJa2MinAAoJEKzQXbSebgfAqncH/1QJGadgYQpo58lkuhbLSgJS LWlPZVVr7vn5+rAOhsODmYaXpJib1Ylukn5ik0yse4YSx8mLoEAIK9ewf7E2Wr67 hnRFeK6SwXFNi2TqqS+mdv/YQ92LrOx57TDywD5dKqTma2sHSwe28NAAICVm4WZG oUuS7NgDYzckQtnJxWqp7tuZsTbzofwMwH5CkzhNmBMj3QAmT60oEqvBFLe55rLE VPqPb1rW8xCiMJIeXLCeynb50YRjAMlZcvKtnFHDVAP+eV0x8fzQqQUPGM3Kp1hX zmsDdeGsPtFN9hNT/yq6Ea1HnpAldoNmfdRyvBSRh0qa7ny92tdIuQlkoIn05N4= =JyDk -----END PGP SIGNATURE----- --EeQfGwPcQSOJBaQU--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20180419164943.GA84360>