Date: Sat, 11 Jan 1997 19:04:36 +1030 (CST) From: Michael Smith <msmith@atrad.adelaide.edu.au> To: charnier@xp11.frmug.org (Philippe Charnier) Cc: hackers@freebsd.org Subject: Re: unused variable in su Message-ID: <199701110834.TAA07745@genesis.atrad.adelaide.edu.au> In-Reply-To: <199701110142.CAA28453@xp11.frmug.org> from Philippe Charnier at "Jan 11, 97 02:42:11 am"
next in thread | previous in thread | raw e-mail | index | archive | help
Philippe Charnier stands accused of saying: > Hello, > > In /usr/src/usr.bin/su/su.c, I get: > line 101: char shellbuf[MAXPATHLEN]; > line 171: shell = strcpy(shellbuf, pwd->pw_shell); > > Shellbuf is not referenced elsewhere, is there any reason not to > remove shellbuf (and adjust line 171), or is there a side effect I don't > see? pwd is recycled later, and shell is potentially reset later, so this is the 'correct' way to do it. Don't change it. > Philippe Charnier charnier@lirmm.fr (smtp) -- ]] Mike Smith, Software Engineer msmith@gsoft.com.au [[ ]] Genesis Software genesis@gsoft.com.au [[ ]] High-speed data acquisition and (GSM mobile) 0411-222-496 [[ ]] realtime instrument control. (ph) +61-8-8267-3493 [[ ]] Unix hardware collector. "Where are your PEZ?" The Tick [[
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199701110834.TAA07745>