Date: Tue, 26 Nov 2002 15:18:53 -0500 From: Hiten Pandya <hiten@angelica.unixdaemons.com> To: Martijn Pronk <martijn@smartie.xs4all.nl> Cc: current@FreeBSD.ORG, Robert Watson <rwatson@FreeBSD.ORG> Subject: Re: Searching for users of netncp and nwfs to help debug 5.0 problems Message-ID: <20021126201853.GC96598@angelica.unixdaemons.com> In-Reply-To: <3DE3C73A.40904@sillywalks.org> References: <Pine.NEB.3.96L.1021121171519.97258b-100000@fledge.watson.org> <3DDE3C34.8020207@sillywalks.org> <3DE3C73A.40904@sillywalks.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Nov 26, 2002 at 08:10:50PM +0100, Martijn Pronk wrote the words in effect of: > Martijn Pronk wrote: > > >Robert Watson wrote: > > > >>The build of netncp is currently broken on 5.0-CURRENT, and I'd like to > >>see this fixed before 5.0-RELEASE. Unfortunately, we're having a lot of > >>trouble finding a test environment, which is the natural and immediate > >>follow-on to the compile fixes :-). Was wondering if anyone with > >>FreeBSD > >>kernel debugging experience and some time on their hands was > >>interested in > >>helping resolve this issue over the next week or two. > >> > > > > > >I can test this next week at work, however, I don't normally use > >netncp & nwfs, > >so it may take me a while. > > > >I'll get back on this next week. > > In file included from /home/src/sys/netncp/ncp_conn.c:46: > /home/src/sys/netncp/ncp_conn.h:174: field `nc_lock' has incomplete type > /home/src/sys/netncp/ncp_conn.h:193: confused by earlier errors, bailing out > *** Error code 1 > > I guess struct lock can't be found. > > I hope someone can do something with this. > Once you change the <sys/lock.h> line in ncp_conn.h to <sys/lockmgr.h>, you will see a lot of struct proc related errors springing up. The motto of this message is, that fixing that line will not make it compile. We need to make sys/netncp use struct thread instead of struct proc. This is easy in some parts of the code, and on some its just a little tricky, but not hard. Somebody did update the prototypes to netncp, but forgot to change the logic, for lockmgr calls, example, its last argument is a struct thread etc. I was going to work on this task at one point in time, but now that my school exam timetable has changed, I will not be able to do it; for the next 2/3 months anyway. If someone wants to give a go at this task, then they are most welcome to take my place. Cheers. -- Hiten Pandya (hiten@unixdaemons.com, hiten@uk.FreeBSD.org) http://www.unixdaemons.com/~hiten/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20021126201853.GC96598>