Date: Sat, 20 Mar 1999 22:30:06 -0800 (PST) From: dawes@xfree86.org To: freebsd-bugs@FreeBSD.org Subject: gnu/10670: cvs doesn't allow digits in local keywords Message-ID: <199903210630.WAA09885@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR gnu/10670; it has been noted by GNATS. From: dawes@xfree86.org To: FreeBSD-gnats-submit@freebsd.org Cc: Subject: gnu/10670: cvs doesn't allow digits in local keywords Date: Fri, 19 Mar 1999 19:52:02 +1100 (EST) >Number: 10670 >Category: gnu >Synopsis: cvs doesn't allow digits in local keywords >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: change-request >Submitter-Id: current-users >Arrival-Date: Fri Mar 19 01:00:01 PST 1999 >Closed-Date: >Last-Modified: >Originator: David Dawes >Release: FreeBSD 4.0-CURRENT i386 >Organization: The XFree86 Project >Environment: Any current release from the active branches >Description: The XFree86 source uses a local RCS keyword "$XFree86$". FreeBSD's version of cvs has support for expanding local RCS keywords, but the code that checks for them only allows them to contain alpha characters. Although this is only an issue for XFree86 developers, changing the behaviour to also allow numerical characters will make it possible for them to use the FreeBSD version of cvs. >How-To-Repeat: Create a $CVSROOT/CVSROOT/options file like: tag=XFree86=CVSHeader check out a file with a $XFree86$ line, and note that it isn't expanded. >Fix: The following patch fixes this: Index: rcs.c =================================================================== RCS file: /home/cvs/src/contrib/cvs/src/rcs.c,v retrieving revision 1.16 diff -u -r1.16 rcs.c --- rcs.c 1998/03/11 09:30:51 1.16 +++ rcs.c 1999/03/19 08:37:55 @@ -3126,7 +3126,7 @@ /* Look for the first non alphabetic character after the '$'. */ send = srch + srch_len; for (s = srch; s < send; s++) - if (! isalpha (*s)) + if (! isalnum (*s)) break; /* If the first non alphabetic character is not '$' or ':', >Release-Note: >Audit-Trail: >Unformatted: To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-bugs" in the body of the message To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-bugs" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199903210630.WAA09885>