Date: Mon, 25 Jun 2018 09:08:15 +0200 From: Lars Engels <lars.engels@0x20.net> To: Gerald Pfeifer <gerald@pfeifer.com> Cc: Michael Danilov <mike.d.ft402@gmail.com>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r472962 - head/net-mgmt/aircrack-ng Message-ID: <20180625070815.GA22494@e.0x20.net> In-Reply-To: <alpine.LSU.2.21.1806221205330.3747@anthias.pfeifer.com> References: <201806210759.w5L7x2cJ042398@repo.freebsd.org> <alpine.LSU.2.21.1806221205330.3747@anthias.pfeifer.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, Jun 23, 2018 at 12:51:31AM +0200, Gerald Pfeifer wrote: > Hi Lars and Michael, > > On Thu, 21 Jun 2018, Lars Engels wrote: > > - Set required GCC version to 6+, so that the default gcc version is chosen. > > GCC isn't needed to successfully building the port, but according to upstream > > > > PR: 228747 > > Submitted by: Michael Danilov <mike.d.ft402@gmail.com> > > > -USE_GCC= 7+ > > +USE_GCC= 6+ > > in that case, the canonical way to state that is > > USE_GCC= yes > > which has the advantage that it'll do what you are aiming for, > without a need to adjust as the default version moves (or if > some user changes the default via Mk/bsd.default-versions.mk). > > I'll be happy to make this change if you agree. Hello Gerald, thanks for the explanation. Feel free to commit the fix. Thanks in advance Lars
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20180625070815.GA22494>