Date: Mon, 07 Oct 2002 18:44:58 -0400 (EDT) From: John Baldwin <jhb@FreeBSD.org> To: "Brian F. Feldman" <green@FreeBSD.org> Cc: cvs-all@FreeBSD.org, cvs-committers@FreeBSD.org, Poul-Henning Kamp <phk@critter.freebsd.dk> Subject: Re: cvs commit: src/sys/boot/i386/boot2 Makefile Message-ID: <XFMail.20021007184458.jhb@FreeBSD.org> In-Reply-To: <200210072235.g97MZEZv006342@green.bikeshed.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 07-Oct-2002 Brian F. Feldman wrote: > Poul-Henning Kamp <phk@critter.freebsd.dk> wrote: >> In message <200210072221.g97MLGNL093580@freefall.freebsd.org>, Brian Feldman wr >> ites: >> >green 2002/10/07 15:21:16 PDT >> > >> > Modified files: >> > sys/boot/i386/boot2 Makefile >> > Log: >> > Correct a bug in adding 0x700 to a number. >> >> It's bedtime here, way past in fact, and I'm not going into the lab >> again to find out what this does/is intended to do. >> >> I succesfully booted on UFS1 and UFS2 without this change, but that >> doesn't necessarily mean that you broke it. >> >> I just hope you know what you're doing... > > At some point someone decided bogusly that the way to add a number to 0x700 > was to concatenate it. I corrected that, so if xread is at an offset of > > 0xff it won't completely fsck itself. Since boot1 is only 512 bytes long and xread is always at the front, I don't see how this is really a problem actually. Sheesh, it used to be a hardcoded constant into boot2 before the script was added! -- John Baldwin <jhb@FreeBSD.org> <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?XFMail.20021007184458.jhb>