Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 4 Dec 2013 08:56:14 -0500
From:      John Baldwin <jhb@freebsd.org>
To:        Eitan Adler <eadler@freebsd.org>
Cc:        "svn-src-head@freebsd.org" <svn-src-head@freebsd.org>, Sean Bruno <sbruno@freebsd.org>, "src-committers@freebsd.org" <src-committers@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>
Subject:   Re: svn commit: r258901 - head/usr.sbin/mfiutil
Message-ID:  <201312040856.14579.jhb@freebsd.org>
In-Reply-To: <CAF6rxg=ZdkSwq26vAE8OMgVUGhWoUCcjxyJ2CO%2BymmTO3xYudA@mail.gmail.com>
References:  <201312040028.rB40Sj9l061474@svn.freebsd.org> <CAF6rxg=ZdkSwq26vAE8OMgVUGhWoUCcjxyJ2CO%2BymmTO3xYudA@mail.gmail.com>

next in thread | previous in thread | raw e-mail | index | archive | help
On Wednesday, December 04, 2013 12:00:16 am Eitan Adler wrote:
> On Tue, Dec 3, 2013 at 7:28 PM, Sean Bruno <sbruno@freebsd.org> wrote:
> > Author: sbruno
> > Date: Wed Dec  4 00:28:44 2013
> > New Revision: 258901
> > URL: http://svnweb.freebsd.org/changeset/base/258901
> >
> > Log:
> >   svn r251516 resized the buf argument a bit too much.  Pass a hardcoded
> >   size of 6 to humanize_number() to resolve this.
> 
> Where is the value of 6 derived from?

It was the old size of buf.  It's a value that allows humanize_number always 
use the largest 2^(10*n) unit.

-- 
John Baldwin



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201312040856.14579.jhb>