Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 30 Nov 2015 22:14:59 GMT
From:      def@FreeBSD.org
To:        svn-soc-all@FreeBSD.org
Subject:   socsvn commit: r294627 - soc2013/def/crashdump-head/sbin/dumpon
Message-ID:  <201511302214.tAUMEx9n090991@socsvn.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: def
Date: Mon Nov 30 22:14:58 2015
New Revision: 294627
URL: http://svnweb.FreeBSD.org/socsvn/?view=rev&rev=294627

Log:
  Zero DIOCSKERNELDUMP argument after use. Style.

Modified:
  soc2013/def/crashdump-head/sbin/dumpon/dumpon.c

Modified: soc2013/def/crashdump-head/sbin/dumpon/dumpon.c
==============================================================================
--- soc2013/def/crashdump-head/sbin/dumpon/dumpon.c	Mon Nov 30 22:06:47 2015	(r294626)
+++ soc2013/def/crashdump-head/sbin/dumpon/dumpon.c	Mon Nov 30 22:14:58 2015	(r294627)
@@ -215,9 +215,11 @@
 			err(EX_OSFILE, "%s", argv[0]);
 		check_size(fd, argv[0]);
 		bzero(&kda, sizeof(kda));
+
 		kda.kda_enable = 0;
 		i = ioctl(fd, DIOCSKERNELDUMP, &kda);
 		bzero(&kda, sizeof(kda));
+
 		if (pubkeyfile != NULL)
 			genkey(pubkeyfile, &kda);
 		kda.kda_enable = 1;
@@ -231,8 +233,10 @@
 		fd = open(_PATH_DEVNULL, O_RDONLY);
 		if (fd < 0)
 			err(EX_OSFILE, "%s", _PATH_DEVNULL);
+
 		kda.kda_enable = 0;
 		i = ioctl(fd, DIOCSKERNELDUMP, &kda);
+		bzero(&kda, sizeof(kda));
 		if (i == 0 && verbose)
 			printf("kernel dumps disabled\n");
 	}



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201511302214.tAUMEx9n090991>