Date: Thu, 25 Jun 2009 14:44:51 +0400 From: Oleg Bulyzhin <oleg@FreeBSD.org> To: Ben Kaduk <minimarmot@gmail.com> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, freebsd-doc@freebsd.org Subject: Re: svn commit: r194930 - in head: sbin/ipfw sys/netinet sys/netinet/ipfw Message-ID: <20090625104451.GA273@lath.rinet.ru> In-Reply-To: <47d0403c0906241644v70f35ba5r7c6440a45c95c369@mail.gmail.com> References: <200906242257.n5OMv71d032996@svn.freebsd.org> <47d0403c0906241644v70f35ba5r7c6440a45c95c369@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Jun 24, 2009 at 07:44:04PM -0400, Ben Kaduk wrote:
> There's a grammar error and a style error, here. I'm actually not
> entirely sure what
> the intended meaning is, so it's a bit hard to fix the grammar error.
It's no wonder - my english writing skill is poor.
> Looking at the code, it seems that in burst mode, extra data will be
> allowed to be sent, though
> it is capped to not exceed the pipe bandwidth.
> Perhaps "... bytes of data is allowed to bypass the dummynet scheduler
> (...), though
> the transmission rate will still be capped so as to not exceed the
> pipe's bandwidth."?
Let me explain. For example, we have pipe with bw 1Mbit/s and burst size is
5GByte. If we try to download 10Gbyte through this pipe following will happen:
1) 1st 5Gbyte of data will go with 'wire speed'.
2) last 5Gbyte will be shaped to 1Mbit/s
Could you please mail me whole 'burst' part (as it should be), and i will fix
it.
>
> The style error is that the new sentence ("Effective burst size ...")
> should start
> on a new line.
>
> I would also prefer to see the new sentence be an actual complete sentence
> (i.e., "The effective burst size is calculated as follows"), though
> there appears
> to be at least one other bug of this form in the file already (see,
> for example, the
> quoted text at the beginning of this hunk: "Default value is no delay.", which
> would benefit from a "the".)
>
>
> Unrelated to this commit, there is a grammar error early in the file:
>
> 312 Once
> 313 .Fl p
> 314 has been specified, any additional arguments as passed on to the preproc
> essor
> 315 for interpretation.
>
> The 'as' in line 314 should be 'are'.
> (This is from CVS r1.220, so the line numbers may not be current.)
>
>
> Thanks,
>
> Ben Kaduk
>
>
> > +MAX(
> > +.Ar size
> > +,
> > +.Nm bw
> > +* pipe_idle_time).
> > +.Pp
> > š.It Cm profile Ar filename
> > šA file specifying the additional overhead incurred in the transmission
> > šof a packet on the link.
> >
--
Oleg.
================================================================
=== Oleg Bulyzhin -- OBUL-RIPN -- OBUL-RIPE -- oleg@rinet.ru ===
================================================================
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20090625104451.GA273>