Date: Mon, 6 Jan 2014 19:30:01 GMT From: Raphael Kubo da Costa <rakuco@FreeBSD.org> To: freebsd-ports-bugs@FreeBSD.org Subject: Re: ports/185455: [PATCH] security/bro: Fix pkg-fallout issue, Message-ID: <201401061930.s06JU1dV064994@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR ports/185455; it has been noted by GNATS.
From: Raphael Kubo da Costa <rakuco@FreeBSD.org>
To: bug-followup@FreeBSD.org
Cc: Craig Leres <leres@ee.lbl.gov>
Subject: Re: ports/185455: [PATCH] security/bro: Fix pkg-fallout issue,
Date: Mon, 06 Jan 2014 21:27:46 +0200
A few comments:
- The LIB_DEPENDS change is incorrect; libraries are still supposed to
be specified as just "libfoo.so".
- The SQLite.cc change also needs to be applied to
src/input/readers/Raw.cc and src/input/readers/SQLite.cc. Please
upstream that as you see fit.
- The patch you've added should probably be renamed as it lacks "src-"
in its name.
- You didn't manage to reproduce the build failures locally because
it's an issue caused by libc++, not clang. If you build with clang
but still use libstdc++, everything works as expected.
I'm going to commit a patch with the changes I've mentioned above.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201401061930.s06JU1dV064994>