Date: Mon, 01 Apr 2002 18:47:24 +0200 From: Poul-Henning Kamp <phk@critter.freebsd.dk> To: Eivind Eklund <eivind@FreeBSD.ORG> Cc: Dag-Erling Smorgrav <des@ofug.org>, "Andrew R. Reiter" <arr@FreeBSD.ORG>, "Greg 'groggy' Lehey" <grog@FreeBSD.ORG>, arch@FreeBSD.ORG Subject: Re: mutex profiling Message-ID: <18325.1017679644@critter.freebsd.dk> In-Reply-To: Your message of "Mon, 01 Apr 2002 18:41:58 %2B0200." <20020401184158.A15491@phoenix.dmnshq.net>
next in thread | previous in thread | raw e-mail | index | archive | help
In message <20020401184158.A15491@phoenix.dmnshq.net>, Eivind Eklund writes: >On Mon, Apr 01, 2002 at 06:31:31PM +0200, Dag-Erling Smorgrav wrote: >> "Andrew R. Reiter" <arr@FreeBSD.org> writes: >> > Can we perhaps have the ability to dump the lock char * description? Or >> > are you doing this way b/c you can get the file and line #'s? Looks good, >> > tho. >> >> I can get both; I'm doing it this way because Eivind did it this way >> and it didn't occur to me to change it. Is one preferrable to the >> other? > >The use of filename/line combinations was done to be able to find what actual >lock aquisitions result in introduction of large amounts of latency. The >basic reason I wrote this patch was to be able to find what parts of our code >result in latency, to focus effort there. > >Measuring the lock types themselves (which is what the lock description would >give you) give a much less granular set of information. This accumulation can >(non-trivially) be done separately, but if you do the accumulation, it is not >possible to recover the information about where the latency is introduced. I think you misunderstood, I think the request was to get the lock name in addition to the file/line info. -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-arch" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?18325.1017679644>