Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 05 Sep 2001 17:27:18 +0300
From:      Maxim Sobolev <sobomax@FreeBSD.org>
To:        Mikhail Teterin <mi@aldan.algebra.com>
Cc:        obrien@FreeBSD.org, ache@nagual.pp.ru, ru@FreeBSD.org, ports@FreeBSD.org, kris@obsecurity.org
Subject:   Re: cvs commit: src/lib/libc/stdlib strtol.c strtoll.c strtoq.c   strtoul.c strtoull.c strtouq.c
Message-ID:  <3B963646.F285276E@FreeBSD.org>
References:  <200109051334.f85DY7o63331@aldan.algebra.com>

next in thread | previous in thread | raw e-mail | index | archive | help
Mikhail Teterin wrote:

> On  5 Sep, Maxim Sobolev wrote:
>
> >> BTW, most of  the patches in the ports-tree don't  have such IDs, but
> >> some  do. Since  those IDs  are discarded  as early  as at  the "make
> >> patch" stage, I  think they are pretty useless --  they don't make it
> >> to the compiled binaries anyway. But what's the general opinion?
>
> > No, they are pretty  useful, IMO. When the user has  a problem you can
> > verify version  of patches he  has and  after the problem  is resolved
> > tell him "update  patxh-xx to the rev.Y.X and you'll  be fine".
>
> Can't  we use  the version  strings of  the ports'  Makefiles? They  are
> supposed to be in sync with the patches. Anyway, you don't say "update X
> to  rev Y".  You say:  "update to  the latest  version of  the port"  --
> nothing but the whole port, and no other version, but the latest one.
>
> Besides, you can  always simply look at the timestamp  of the patch. The
> usefullness of the rcs (and other) ids  in the sources, is that they let
> the ids make  it into the binaries,  where they can be  read by ident(1)
> and similar tools. Ids in patch files don't make into the binaries...

This is an oversimplistic view. Ids in many files in our src tree don't go
into binaries (think about header files).

-Maxim


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-ports" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?3B963646.F285276E>