Date: Wed, 8 May 2013 20:21:12 +0200 From: Attilio Rao <attilio@freebsd.org> To: John Baldwin <jhb@freebsd.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r250339 - head/sys/x86/acpica Message-ID: <CAJ-FndD4=5f3ydSuRLqL%2BcqTTDfGyjXAxaWTMQOWLfK29Z8RUw@mail.gmail.com> In-Reply-To: <201305081201.16405.jhb@freebsd.org> References: <201305072249.r47MnvrO009846@svn.freebsd.org> <201305081201.16405.jhb@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, May 8, 2013 at 6:01 PM, John Baldwin <jhb@freebsd.org> wrote: > On Tuesday, May 07, 2013 6:49:57 pm Attilio Rao wrote: >> Author: attilio >> Date: Tue May 7 22:49:56 2013 >> New Revision: 250339 >> URL: http://svnweb.freebsd.org/changeset/base/250339 >> >> Log: >> Add functions to do ACPI System Locality Information Table parsing >> and printing at boot. >> For reference on table informations and purposes please review ACPI specs. >> >> Sponsored by: EMC / Isilon storage division >> Obtained from: jeff >> Reviewed by: jhb (earlier version) > > Eh, I don't recall reviewing this. However, acpidump already dumps this > table, and we should dump tables via acpidump, not in dmesg. Now that I read better this patch is based upon a patch you submitted originally (see the private thread NUMA WIP). We already print some useful ACPI table information at boot really (APIC ACPI table case) and this is only printed out when having MAXMEMDOM > 1. Finally I have also sent you this patch and you didn't object. However if you really dislike it I can print under bootverbose maybe? Attilio -- Peace can only be achieved by understanding - A. Einstein
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAJ-FndD4=5f3ydSuRLqL%2BcqTTDfGyjXAxaWTMQOWLfK29Z8RUw>