Date: Thu, 03 May 2007 10:20:22 -0700 From: Colin Percival <cperciva@freebsd.org> To: Tim Kientzle <kientzle@freebsd.org> Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/usr.bin/tar write.c Message-ID: <463A19D6.6070400@freebsd.org> In-Reply-To: <46397035.7000606@freebsd.org> References: <200705030433.l434XBvW005733@repoman.freebsd.org> <46397035.7000606@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Tim Kientzle wrote: > I wonder if it would be simpler to set non-zero exit only > if this is the first path returned from tree_next() (which > should be the path given on the command line). That > would avoid the headache of having to perform a textual > path comparison. > > A simple flag to indicate if this is the first time > through the loop should suffice, I think. Hmm... I considered this, but I wasn't sure if there were any edge cases where the first path returned by tree_next might not be the path passed to tree_open; so I decided to take the route which I knew would always work. If you're sure that a first-time-through-the-loop flag will work, feel free to change this. :-) Colin Percival
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?463A19D6.6070400>