Date: Mon, 15 Mar 2004 16:20:14 -0800 (PST) From: Oliver Eikemeier <eikemeier@fillmore-labs.com> To: freebsd-ports-bugs@FreeBSD.org Subject: Re: ports/64317: Update of german/BBBike port Message-ID: <200403160020.i2G0KErx003056@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR ports/64317; it has been noted by GNATS.
From: Oliver Eikemeier <eikemeier@fillmore-labs.com>
To: slaven@rezic.de
Cc: FreeBSD-gnats-submit@FreeBSD.org
Subject: Re: ports/64317: Update of german/BBBike port
Date: Tue, 16 Mar 2004 01:19:50 +0100
Slaven Rezic wrote:
> Oliver Eikemeier <eikemeier@fillmore-labs.com> writes:
>
>>> .include <bsd.port.mk>
>>>+
>>>+.if !defined(PERL_VER) || ${PERL_VER} == 5.005
>>>+PLIST= ${PKGDIR}/pkg-plist.5005
>>>+LOCAL_PERL_ARCH!=${PERL5} -MConfig -e 'print qq{$$Config{archname}}'
>>>+.else
>>>+LOCAL_PERL_ARCH!=${PERL5} -MConfig -e 'print qq{$$Config{version}/$$Config{archname}}'
>>>+.endif
>>
>>please check your port with portlint before submitting
>
> I do (4 warnings, no error).
It is supposed to say:
FATAL: Makefile: do not include anything after bsd.port(.post).mk
could you check that you have the latest version of portlint and send me
the port as a shar if you still get no error?
>>- never write anything after bsd.port(.post).mk
>
> I am open to better solutions. Unfortunately I need to pass the
> "LOCAL_PERL_ARCH" variable for pkg-plist generation, which in turn
> needs the current value of some perl Config variables. PERL5 is only
> defined after including bsd.port.mk, so this part had to go after the
> include.
If you got a problem like this, *please* don't hack around the port system.
These things might need a lot of work to clean up. Try asking for help
on perl@ and ports@.
We have things like PERL_VERSION and PERL_ARCH, so it should be doable.
If a variable is missing, please post this to ports, so we can fix this.
>>- this will break `make describe' on systems without perl installed
>
> I can skip this part if perl is missing. How to detect this reliably?
> By checking the existance of /usr/bin/perl5?
You can't. The system might have no perl installed when the Makefile is
parsed, but get perl added as dependency (because of USE_PERL5=yes).
Generally, using != in ports is a bad idea. Really. Please?
-Oliver
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200403160020.i2G0KErx003056>