Date: Fri, 21 Jan 2000 23:09:47 -0700 From: Brett Glass <brett@lariat.org> To: gdonl@tsc.tdk.com (Don Lewis), Matthew Dillon <dillon@apollo.backplane.com>, Giorgos Keramidas <charon@hades.hell.gr> Cc: Warner Losh <imp@village.org>, Darren Reed <avalon@coombs.anu.edu.au>, security@FreeBSD.ORG Subject: Re: stream.c worst-case kernel paths Message-ID: <4.2.2.20000121230038.019685e0@localhost> In-Reply-To: <200001220551.VAA15775@salsa.gv.tsc.tdk.com> References: <Matthew Dillon <dillon@apollo.backplane.com>
next in thread | previous in thread | raw e-mail | index | archive | help
At 10:51 PM 1/21/2000 , Don Lewis wrote:
>+ if ((thflags & (TH_ACK|TH_SYN)) == TH_SYN)
>+ wildcard = 1;
Looks good! But wouldn't it be better to do:
if ((thflags & (TH_RST|TH_ACK|TH_SYN)) == TH_SYN)
wildcard = 1;
to make sure it's really a legitimate SYN? And what
about SYN-FIN packets? (If we want to avoid looking
for a listener on those, we need to "or" TH_FIN into the
inntermost constant expression too.)
--Brett
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-security" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4.2.2.20000121230038.019685e0>