Date: Tue, 17 Feb 2015 10:15:57 +0100 From: John Marino <freebsd.contact@marino.st> To: Alexey Dokuchaev <danfe@FreeBSD.org>, "Vanilla I. Shu" <vanilla@FreeBSD.org> Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r379069 - head/sysutils/shlock Message-ID: <54E306CD.9020102@marino.st> In-Reply-To: <20150217090530.GA41942@FreeBSD.org> References: <201502160749.t1G7nUhH066516@svn.freebsd.org> <20150217090530.GA41942@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 2/17/2015 10:05, Alexey Dokuchaev wrote: > On Mon, Feb 16, 2015 at 07:49:30AM +0000, Vanilla I. Shu wrote: >> New Revision: 379069 >> URL: https://svnweb.freebsd.org/changeset/ports/379069 >> QAT: https://qat.redports.org/buildarchive/r379069/ >> >> Log: >> Upgrade to 2.5.4. >> >> PR: 197456 >> Submitted by: Ports Fury. >> [...] >> -PLIST_FILES= bin/${PORTNAME} man/man1/${PORTNAME}.1.gz >> +PLIST_FILES= bin/shlock man/man1/shlock.1.gz > > Gratuitous change that has nothing to do with version upgrade. Maybe not, but it's a good change. Any time the port will break if the PORTNAME changes, this kind of change should be made. disclaimer: using ${PORTNAME} like that is a pet peeve of mine. >> @@ -1,5 +1,5 @@ >> -The historical, and still very useful process-locking program. Use to make >> -sure that your shell script is the only version of itself running on your >> -system. There are many other creative ways to use this program. >> +The historical, and still very useful process-locking program. Use to >> +make sure that your shell script is the only version of itself running >> +on your system. There are many other creative ways to use this program. > > Ditto. Please do not cause repochurn. Kato's PRs are full of this shit. Had these lines been over 75 characters, I would not have agreed. We should be wrapping at 75. I do this fairly often myself. However, the original pkg-descr was already wrapped at 75. We can't get too wrapped around the axle on unmaintained ports for aesthetic changes. That said, I've seen a few "downgrades" from tkato myself, recently the conversion of multi-line single commands with multiple arguments to a loop of commands with one argument. John
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?54E306CD.9020102>