Date: Fri, 4 Sep 2009 12:32:14 +0200 From: Ed Schouten <ed@80386.nl> To: "Andrey A. Chernov" <ache@FreeBSD.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r196818 - head/contrib/ee Message-ID: <20090904103214.GW2829@hoeg.nl> In-Reply-To: <200909040742.n847gD62058267@svn.freebsd.org> References: <200909040742.n847gD62058267@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--S2CovAv8lqFB/Tem Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hello Andrey, * Andrey A. Chernov <ache@FreeBSD.org> wrote: > 1) Remove single occurance of HAS_CTYPE ifdef, ctype functions > used here for a long time and needs their header in anycase. > 2) Add (unsigned char) casts to more ctype macros. > 3) Simplify menu input handling using ctype instead of range unguarded > hardcoded tricks. Even though I really appreciate fixes/cleanups to ee(1), I think changes like these should be sent to its maintainer as well. Have you done this? --=20 Ed Schouten <ed@80386.nl> WWW: http://80386.nl/ --S2CovAv8lqFB/Tem Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (FreeBSD) iEYEARECAAYFAkqg7K4ACgkQ52SDGA2eCwXM2QCePT8DwLBxvB05e0nTuK1//1+g PRwAn1yb9FC4hPRQ8Or8PWJL8dSzRbHW =BNFE -----END PGP SIGNATURE----- --S2CovAv8lqFB/Tem--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20090904103214.GW2829>