Date: Sun, 4 Nov 2012 14:40:06 +0100 From: Jilles Tjoelker <jilles@stack.nl> To: Chris Rees <utisoft@gmail.com> Cc: freebsd-rc@FreeBSD.org Subject: Re: conf/166484: [rc] [patch] rc.initdiskless patch for different major versions living together Message-ID: <20121104134006.GA35520@stack.nl> In-Reply-To: <201211041230.qA4CU1fT000866@freefall.freebsd.org> References: <201211041230.qA4CU1fT000866@freefall.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, Nov 04, 2012 at 12:30:01PM +0000, Chris Rees wrote:
> The following reply was made to PR conf/166484; it has been noted by GNATS.
> From: Chris Rees <utisoft@gmail.com>
> To: "bug-followup@freebsd.org" <bug-followup@freebsd.org>
> Cc:
> Subject: Re: conf/166484: [rc] [patch] rc.initdiskless patch for different
> major versions living together
> Date: Sun, 4 Nov 2012 12:21:22 +0000
> I think this is a great idea.
> My only concern is the backslashitis in the finding of $rel, and also
> the fact that it won't catch 10 properly :)
> Instead of:
> rel=`expr \`uname -r\` : '\(.\)'`
> try:
> rel=$(expr `uname -r` : '\([0-9][0-9]*\)')
> Does anyone else have any opinions?
The shell command should be:
rel=$(uname -r)
rel=${rel%%.*}
Is it deliberate that the major release replaces base while the other
items like bcast/${ipba} and ip/${ip} add to it? I think so, with the
assumption that base.${rel} will be a straight copy of the results of
make installworld and make distribution with a DESTDIR, all local
changes living in the source tree or the other directories
rc.initdiskless uses.
--
Jilles Tjoelker
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20121104134006.GA35520>