Date: Sun, 11 Mar 2018 12:06:00 +0200 From: Konstantin Belousov <kostikbel@gmail.com> To: Jeff Roberson <jeff@FreeBSD.org> Cc: src-committers@freebsd.org, svn-src-user@freebsd.org Subject: Re: svn commit: r330755 - user/jeff/numa/sys/vm Message-ID: <20180311100600.GB76926@kib.kiev.ua> In-Reply-To: <201803110245.w2B2jrhF037791@repo.freebsd.org> References: <201803110245.w2B2jrhF037791@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, Mar 11, 2018 at 02:45:53AM +0000, Jeff Roberson wrote: > Author: jeff > Date: Sun Mar 11 02:45:52 2018 > New Revision: 330755 > URL: https://svnweb.freebsd.org/changeset/base/330755 > > Log: > Leave a note for myself to cleanup some locking before commit to head. > > Modified: > user/jeff/numa/sys/vm/vm_page.c > > Modified: user/jeff/numa/sys/vm/vm_page.c > ============================================================================== > --- user/jeff/numa/sys/vm/vm_page.c Sun Mar 11 01:09:31 2018 (r330754) > +++ user/jeff/numa/sys/vm/vm_page.c Sun Mar 11 02:45:52 2018 (r330755) > @@ -3374,6 +3374,7 @@ vm_page_free_pages_toq(struct spglist *free, bool upda > while ((m = SLIST_FIRST(free)) != NULL) { > count++; > SLIST_REMOVE_HEAD(free, plinks.s.ss); > + /* XXX batch locks. */ > vm_page_lock(m); > if (vm_page_free_prep(m, false)) > TAILQ_INSERT_TAIL(&pgl, m, listq); Is the added vm_page_lock() due to the new uses of vm_page_free_pages_toq() ? I believe that the function was only used for the unmanaged pages.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20180311100600.GB76926>