Date: Sat, 28 Nov 2009 00:30:42 +0200
From: Kostik Belousov <kostikbel@gmail.com>
To: Joe Marcus Clarke <marcus@freebsd.org>
Cc: "threads@freebsd.org" <threads@freebsd.org>
Subject: Re: [PATCH] Add missing pthread_condattr_{init, destroy} stubs to libc
Message-ID: <20091127223042.GM2368@deviant.kiev.zoral.com.ua>
In-Reply-To: <1259360887.1608.49.camel@shumai.marcuscom.com>
References: <1259298918.1608.19.camel@shumai.marcuscom.com> <20091127131242.GA2368@deviant.kiev.zoral.com.ua> <1259349248.1608.36.camel@shumai.marcuscom.com> <4AF1E295-0524-4C39-94CD-9A12D574C64D@vigrid.com> <20091127213046.GI2368@deviant.kiev.zoral.com.ua> <1259358800.1608.46.camel@shumai.marcuscom.com> <20091127220706.GJ2368@deviant.kiev.zoral.com.ua> <1259359873.1608.48.camel@shumai.marcuscom.com> <20091127222224.GL2368@deviant.kiev.zoral.com.ua> <1259360887.1608.49.camel@shumai.marcuscom.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--yklP1rR72f9kjNtc Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Nov 27, 2009 at 05:28:07PM -0500, Joe Marcus Clarke wrote: > On Sat, 2009-11-28 at 00:22 +0200, Kostik Belousov wrote: > > On Fri, Nov 27, 2009 at 05:11:13PM -0500, Joe Marcus Clarke wrote: > > > I didn't see a better way of fixing this. I'm still fuzzy on how to = do > > > the correct symbol map dance for libthr/libc_r. Do you know of any > > > example symbols which had to be updated in this fashion? > >=20 > > pthread_condattr_init and _destroy are exported from libthr in FBSD_1.0. > > namespace. I think stubs should go into FBSD_1.0 namespace in libc then. > >=20 > > We nullified one of the use for symver by extending existing > > namespaces (symbol versioning, as defined by Sun, allowed for dynamic > > linker to make a guarantee that process does not have unresolved > > symbols only by checking that all required versions are provided > > by libraries). My opinion that adding them to FBSD_1.0 is ok. >=20 > That's easy enough. New patch is up. >=20 > http://www.marcuscom.com/downloads/stubs.diff I think symbols should be added in the pthread_* block of the libc/gen/Symbol.map, arranged alphabetically. --yklP1rR72f9kjNtc Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (FreeBSD) iEYEARECAAYFAksQUxIACgkQC3+MBN1Mb4hbcwCfehMfWbZBUOtfEf3QxZbIvlJE /TsAnRrkxhd9xSNrm94DeiZ0cVGieINV =7/Bw -----END PGP SIGNATURE----- --yklP1rR72f9kjNtc--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20091127223042.GM2368>