Date: Wed, 05 Nov 2008 04:18:54 +0200 From: Giorgos Keramidas <keramida@freebsd.org> To: "Ivan Voras" <ivoras@gmail.com> Cc: Diomidis Spinellis <dds@aueb.gr>, svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r184645 - head/usr.bin/vmstat Message-ID: <87y6zygbjl.fsf@kobe.laptop> In-Reply-To: <9bbcef730811041416o6eaf3033k459fb4d29c9e231a@mail.gmail.com> (Ivan Voras's message of "Tue, 4 Nov 2008 23:16:39 %2B0100") References: <200811041802.mA4I2aVk003708@svn.freebsd.org> <BA9CF772-DA8B-429E-BDB8-73A65FA8CC5B@aueb.gr> <9bbcef730811041416o6eaf3033k459fb4d29c9e231a@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, 4 Nov 2008 23:16:39 +0100, "Ivan Voras" <ivoras@gmail.com> wrote: > 2008/11/4 Diomidis Spinellis <dds@aueb.gr>: >> On Nov 4, 2008, at 8:02 PM, Giorgos Keramidas wrote: >> >>> Author: keramida (doc committer) >>> Date: Tue Nov 4 18:02:35 2008 >>> New Revision: 184645 >>> URL: http://svn.freebsd.org/changeset/base/184645 >>> >>> Log: >>> Repeat vmstat header after window.rows instead of a hardcoded 20. > >> Thanks! This functionality is generally useful and tricky to code in a >> correct way. > > Any objections to > > http://people.freebsd.org/~ivoras/diffs/vmstat.c.patch.txt ? > > It uses humanize_number on interrupt, syscall and context switch counts. It's great! I'm only a bit worried about breaking many people's scripts if we change the format to include humanized numbers by default, so I would like to see a similar patch committed but disabled by default for a while (and enabled by a command-line option like `-h'). The `-h' option seems to be the BSD equivalent of what GNU people would call `--humanized-output'. It would be nice to have vmstat and iostat display humanized numbers but let's keep the default to its traditional style and make the new output style accessible too :)
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?87y6zygbjl.fsf>