Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 3 Oct 2006 05:19:36 GMT
From:      Warner Losh <imp@FreeBSD.org>
To:        Perforce Change Reviews <perforce@freebsd.org>
Subject:   PERFORCE change 107141 for review
Message-ID:  <200610030519.k935JaTf000860@repoman.freebsd.org>

next in thread | raw e-mail | index | archive | help
http://perforce.freebsd.org/chv.cgi?CH=107141

Change 107141 by imp@imp_lighthouse on 2006/10/03 05:19:19

	Better panic messages

Affected files ...

.. //depot/projects/arm/src/sys/dev/mmc/mmc.c#17 edit

Differences ...

==== //depot/projects/arm/src/sys/dev/mmc/mmc.c#17 (text+ko) ====

@@ -128,7 +128,7 @@
 	sc = device_get_softc(busdev);
 	MMC_LOCK(sc);
 	if (sc->owner)
-		panic("How did I get here?");
+		panic("mmc: host bridge didn't seralize us.");
 	sc->owner = dev;
 	MMC_UNLOCK(sc);
 	return (0);
@@ -143,9 +143,9 @@
 	sc = device_get_softc(busdev);
 	MMC_LOCK(sc);
 	if (!sc->owner)
-		panic("No owner?");
+		panic("mmc: releasing unowned bus.");
 	if (sc->owner != dev)
-		panic("Wrong owner releasing?");
+		panic("mmc: you don't own the bus.  game over.");
 	MMC_UNLOCK(sc);
 	err = MMCBR_RELEASE_HOST(device_get_parent(busdev), dev);
 	if (err)



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200610030519.k935JaTf000860>